Merge pull request #45 from necromant2005/master

skip session regenerate id when session is not started

Author: weierophinney

src/SessionManager.php

@@ -320,7 +320,10 @@ public function getId()
      */
     public function regenerateId($deleteOldSession = true)
     {
-        session_regenerate_id((bool) $deleteOldSession);
+        if ($this->sessionExists()) { 
+            session_regenerate_id((bool) $deleteOldSession);
+        }
+
         return $this;
     }
 

test/SessionManagerTest.php

@@ -433,6 +433,17 @@ public function testRegenerateIdShouldWorkAfterSessionStarted()
         $this->assertNotSame($origId, $this->manager->getId());
     }
 
+    /**
+     * @runInSeparateProcess
+     */
+    public function testRegenerateIdDoesNothingWhenSessioIsNotStarted()
+    {
+        $origId = $this->manager->getId();
+        $this->manager->regenerateId();
+        $this->assertEquals($origId, $this->manager->getId());
+        $this->assertEquals('', $this->manager->getId());
+    }
+
     /**
      * @runInSeparateProcess
      */