PHP 8.4 support by adding Odbc\Connection handling #216
Merged
Conversation
- Added support for running unit tests using SQLite by introducing `mockDb2UsingSqlite` config option. - Refactored DSN handling with a `buildDsn` method for better maintainability. - Fixed issues with ODBC connection handling, improving compatibility with PHP 8.4. - Updated tests to dynamically determine the DSN based on the configuration. This makes it easier to run tests without an IBM i system and allows for automated testing across multiple PHP versions.
Updated the `$databaseNameOrResource` parameter to support `Odbc\Connection`, expanding compatibility for database connections.
NattyNarwhal
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This PR fixes a few missed spots in the PHP 8.4 compatibility update by properly supporting
Odbc\Connection.Changes:
Odbc\Connection.Odbc\Connection.