Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate without punctuation #70

Open
zephyrtronium opened this issue Aug 27, 2024 · 3 comments
Open

generate without punctuation #70

zephyrtronium opened this issue Aug 27, 2024 · 3 comments

Comments

@zephyrtronium
Copy link
Owner

It would be nice to be able to generate e.g. bocchi: ryo with the colon when given only bocchi without a colon as prompt. This was one of the goals of #45. It doesn't work now, probably due to the extra space added at the end of the last token by brain.Tokens.

@zephyrtronium
Copy link
Owner Author

This may also be related to the phenomenon where Robot happens to pick an empty continuation for a prompt and thereby speaks nothing.

@seth-rah
Copy link
Contributor

I'm not sure, but would this also impact capitalization?

If someone uses Bocchi instead of bocchi would that make a difference?

@zephyrtronium
Copy link
Owner Author

Robot already ignores capitalization in the prompt, as well as during continuation generally. Probably worth clarifying that the goal here is not to have Robot ignore punctuation for all continuation, only to allow selecting a punctuation token as the first one following the prompt. Currently that doesn't work because Robot affixes a space to the last token in the prompt, which is done primarily because the same tokenization function is used for both learning and speaking and doing that made the former simpler. But since the tokens in bocchi: ryo are bocchi : ryo , it doesn't match when we tokenize a prompt of bocchi into bocchi .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants