Commit 6d0f530
clear up props registry in shared backend on js thread (facebook#56677)
Summary:
## Changelog:
[Internal] [Fixed] - clear up props registry in shared backend on js thread
stopSurface is usually called from main thread, but `animatedPropsRegistry_->getMap` in animationBackendCommitHook is called from js thread. Removing the surface props entry on ui thread can cause race condition (getMap() result on js thread becomes undefined)
https://www.internalfb.com/code/fbsource/[26d70084020e]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.cpp?lines=26-31
Reviewed By: christophpurrer
Differential Revision: D1037527091 parent fbdbf4a commit 6d0f530
1 file changed
Lines changed: 12 additions & 4 deletions
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | 278 | | |
283 | 279 | | |
284 | 280 | | |
| |||
295 | 291 | | |
296 | 292 | | |
297 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
298 | 306 | | |
299 | 307 | | |
300 | 308 | | |
| |||
0 commit comments