Github: Does not detect when soft-navigating

[adomasven]

Report: https://forums.zotero.org/discussion/125806/firefox-connector-github-detection-not-always-reliable-report-id-1259862449

I've reproduced this on Chrome too. The translator exits at https://github.com/zotero/translators/blob/master/GitHub.js#L43

[alex-ter]

I've looked into this, and there seems to be no easy solution in sight. The reason is that upon such page transition, there are no og: tags at all and a sizeable part of logic relies on those, even beyond that detectWeb() line.

There is a couple of places where the org/repo pair could be gleaned from, like

<link rel="canonical" href="https://github.com/zotero/translators" data-turbo-transient="">

and

<meta name="octolytics-dimension-repository_nwo" content="zotero/translators">

...but they are also inconsistent - the former exists on the Code and Pulls tabs, but not others, and does not work for files or directories, while the latter mostly refreshes during soft-navigation, but sometimes doesn't, and sometimes disappears.

The breadcrumbs could theoretically be parsed too, as they are consistently refreshed, being a part of the UI, but I haven't analyzed this an any detail (ran out of time I had for this today). Hope this helps.

[AbeJellinek]

Yeah, this is taking some work to rely more on the API than the meta tags, but I have a PR in progress.