Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed links crash the client #1247

Closed
tmichela opened this issue Nov 16, 2022 · 1 comment
Closed

Malformed links crash the client #1247

tmichela opened this issue Nov 16, 2022 · 1 comment

Comments

@tmichela
Copy link

Describe the bug

Having a malformed hyperlink cause the desktop client to crash.

To Reproduce

write a comment with a malformed link and click on it, e.g. [this is a link](this is not an url)

Expected behavior

no crash

Desktop (please complete the following information):

  • Operating System: macOS 11.7.1
  • Zulip Desktop Version: 5.9.3
@andersk
Copy link
Member

andersk commented Jan 5, 2023

I believe this has been resolved in Zulip Desktop 5.9.4 by the upgrade to Electron 22.0.0 (#1259) and/or the exception handler added in 94780c4. If you see this crash again after upgrading to 5.9.4, please let us know. Thanks!

@andersk andersk closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants