Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize notification channel name #1284

Open
PIG208 opened this issue Jan 15, 2025 · 0 comments
Open

Internationalize notification channel name #1284

PIG208 opened this issue Jan 15, 2025 · 0 comments
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-i18n Translation, localization, internationalization a-notifications
Milestone

Comments

@PIG208
Copy link
Member

PIG208 commented Jan 15, 2025

When we create the notification channel, the name is hard-coded as "Messages". This is the same name that appears in the user's notification setting:

Image

We could access GlobalLocalizations.zulipLocalizations while ensuring that the app has started (so that it is set to use the right locale), when initially setting up the notification channel. This only happens when using the app for the first time. We might be able to update the name through createNotificationChannel.

Just updating the channel name whenever the app is started is not enough, though. We also want to listen to changes to the locale and update the name whenever that happens. Flutter probably listens to that already so we might find a way to utilize that.

This is a follow-up to:

@PIG208 PIG208 added this to the M7: Future milestone Jan 15, 2025
@PIG208 PIG208 added a-i18n Translation, localization, internationalization a-notifications labels Jan 15, 2025
@PIG208 PIG208 changed the title Internationalize the notification channel name Internationalize notification channel name Jan 15, 2025
@gnprice gnprice added the a-Android Issues specific to Android, or requiring Android-specific work label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-i18n Translation, localization, internationalization a-notifications
Projects
Status: No status
Development

No branches or pull requests

2 participants