Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer "Mark channel as read" in channel action sheet #1226

Open
chrisbobbe opened this issue Dec 27, 2024 · 6 comments · May be fixed by #1317
Open

Offer "Mark channel as read" in channel action sheet #1226

chrisbobbe opened this issue Dec 27, 2024 · 6 comments · May be fixed by #1317
Assignees
@chimnayajith
Labels
beta feedback Things beta users have specifically asked for help wanted
Milestone
M5: Launch

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 27, 2024 •
edited
Loading

We haven't yet built a channel action sheet, but I think we plan to, as a home for

We should include a mark-as-read action in that action sheet. This came up in beta feedback on CZO:

In the channel list, a long press on the channel name should bring up a menu with options like "Mark all read" and "unsubscribe" and "copy link". That menu was available in the old app.

Related issues
@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 27, 2024
This was referenced Dec 27, 2024
Open
Open
@chrisbobbe
Copy link
Collaborator Author

This came up in beta feedback on CZO:

In the channel list, a long press on the channel name should bring up a menu with options like "Mark all read" and "unsubscribe" and "copy link". That menu was available in the old app.

@gnprice gnprice added this to the M6: Post-launch milestone Dec 28, 2024
@AshutoshKhadse23

This comment was marked as resolved.

Sign in to view
@chrisbobbe

This comment was marked as resolved.

Sign in to view
@AffanShaikhsurab
Copy link

hi can i work on this issue > looks intresting ! , this is my first pr so any tips ?

@gnprice gnprice modified the milestones: M6: Post-launch, M5: Launch Jan 14, 2025
@chrisbobbe
Copy link
Collaborator Author

This isn't the best issue for a new contributor, as we haven't built the channel action sheet yet. I suggest choosing a different issue.

Here is the Zulip project's guide to getting involved with the code:

https://zulip.readthedocs.io/en/latest/contributing/contributing.html#your-first-codebase-contribution
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on

chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 2, 2025
action_sheet: Add channel action sheet with mark as read option
d8801d9 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 2, 2025
action_sheet: Add channel action sheet with mark as read option
8d23d3b 
Fixes: zulip#1226
@chimnayajith chimnayajith linked a pull request Feb 2, 2025 that will close this issue
Open
@chimnayajith
Copy link

I've opened a PR for this issue. Please take a look. Thank you!

chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
action_sheet: Add channel action sheet with mark as read option
d087994 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
action_sheet: Add channel action sheet with mark as read option
0a8811a 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
action_sheet: Add channel action sheet with mark as read option
8a4937e 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 6, 2025
action_sheet: Add channel action sheet with mark as read option
fe731f6 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 6, 2025
action_sheet: Add channel action sheet with mark as read option
72ac73d 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 6, 2025
action_sheet: Add channel action sheet with mark as read option
06ed689 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 6, 2025
action_sheet: Add channel action sheet with mark as read option
93d3199 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 7, 2025
action_sheet: Add channel action sheet with mark as read option
26973af 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 7, 2025
action_sheet: Add channel action sheet with mark as read option
5768d19 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 7, 2025
action_sheet: Add channel action sheet with mark as read option
da7af54 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 11, 2025
action_sheet: Add channel action sheet with mark as read option
ad68d72 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 11, 2025
action_sheet: Add channel action sheet with mark as read option
9b825ee 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 11, 2025
action_sheet: Add channel action sheet with mark as read option
2a5b01d 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 15, 2025
action_sheet: Add channel action sheet with mark as read option
e5af07a 
Fixes: zulip#1226
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 19, 2025
action_sheet: Add channel action sheet with mark as read option
fe82a57 
Fixes: zulip#1226
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Feb 19, 2025
@chimnayajith
action_sheet: Add channel action sheet with mark as read option
85bd888 
Fixes: zulip#1226
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Feb 19, 2025
@chimnayajith
action_sheet: Add channel action sheet with mark as read option
04d8daa 
Fixes: zulip#1226
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Feb 19, 2025
@chimnayajith
action_sheet: Add channel action sheet with mark as read option
680f54f 
Fixes: zulip#1226
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Feb 20, 2025
@chimnayajith
action_sheet: Add channel action sheet with mark as read option
391bc6e 
Fixes: zulip#1226
@chrisbobbe chrisbobbe mentioned this issue Feb 20, 2025
Closed
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Feb 21, 2025
@chimnayajith
action_sheet: Add channel action sheet with mark as read option
622ac32 
Fixes: zulip#1226
@chrisbobbe chrisbobbe mentioned this issue Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chimnayajith chimnayajith

Labels
beta feedback Things beta users have specifically asked for help wanted
Projects
Flutter app
Status: No status
Milestone
M5: Launch
Development

Successfully merging a pull request may close this issue.

action_sheet: Offer "Mark channel as read" in channel action sheet chimnayajith/zulip-flutter
5 participants
@gnprice @chrisbobbe @AffanShaikhsurab @chimnayajith @AshutoshKhadse23