Offer a list of all channels, and a way to subscribe #188
Comments
gnprice
added
the
a-home
gnprice
added a commit
that referenced
this issue
Jun 14, 2023
|
Hey @gnprice I'd like to work on this issue. I'd love some help regarding the UI implementation.
|
|
Yes indeed — this screen should show all streams. (Well, all streams that the user is able to see.) Cross-referencing, we have a more detailed discussion in this chat thread: |
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Jul 29, 2024
Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Jul 29, 2024
Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 7, 2024
Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 8, 2024
Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 12, 2024
Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 22, 2024
This creates the page that contains all channels list, still we need to implement subscribe/unsubscribe logic which will be introduced in the upcoming commits. Fixes parts of zulip#188 channel_list: Show a label when no channels are found channel_list: Order channels alphabetically
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 22, 2024
This creates the page that contains all channels list, still we need to implement subscribe/unsubscribe logic which will be introduced in the upcoming commits. Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Aug 29, 2024
This creates the page that contains all channels list, still we need to implement subscribe/unsubscribe logic which will be introduced in the upcoming commits. Fixes parts of zulip#188
Khader-1
added a commit
to Khader-1/zulip-flutter
that referenced
this issue
Nov 19, 2024
This creates the page that contains all channels list, still we need to implement subscribe/unsubscribe logic which will be introduced in the upcoming commits. Fixes parts of zulip#188
gnprice
changed the title
|
This feature now has a design in Figma (thanks Vlad!). I've updated the description to reflect that. |
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Apr 30, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should pick a color even for the subscribed streams, as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed streams are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Apr 30, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should pick a color even for the subscribed streams, as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed streams are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Apr 30, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should pick a color for the unsubscribed streams, as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed streams are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Apr 30, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should pick a color for the unsubscribed streams, as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed streams are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Apr 30, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should generate different colors within constraints for the unsubscribed channels (since only subscribed channels have color data from the server), as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed channels are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
May 1, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should generate different colors within constraints for the unsubscribed channels (since only subscribed channels have color data from the server), as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed channels are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
May 1, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should pick a color for the unsubscribed streams, as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed streams are needed, namely the topic list.
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
May 1, 2025
Looking into the design requirement a bit more, we initially fall back to this color because we didn't have the logic to generate channel colors: https://chat.zulip.org/#narrow/channel/48-mobile/topic/All.20channels.20screen.20-.20.23F832/near/1904009 This replaces the ad-hoc colors with generated colors based on a fallback base color. The base color we fall back to is still a placeholder. Ideally, we should generate different colors within constraints for the unsubscribed channels (since only subscribed channels have color data from the server), as shown in the Figma design linked in zulip#188. That issue is out-of-scope for this, though. For now, it's sufficient to just remove the ad-hoc color on MessageListTheme. This way we don't have to reuse it in places where colors for unsubscribed channels are needed, namely the topic list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes one wants to navigate to a channel/stream when not already subscribed, or to subscribe to a channel.
Like in zulip-mobile, we'll offer this functionality as an "All channels" screen, reached from a button at the bottom of the "Channels" tab.
Design
This screen has a design in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=7723-6411&m=dev
See there for details, including some notes.
Differences from Figma:
The text was updated successfully, but these errors were encountered: