Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecentDmConversationsPage: Design / implement appearance when empty #385

Open
chrisbobbe opened this issue Nov 17, 2023 · 4 comments
Open
Labels
a-design Visual and UX design a-home The home screens of the app; finding and starting conversations

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Nov 17, 2023

When the user doesn't have any recent DM conversations, RecentDmConversationsPage (titled "Direct messages") should have a message saying so, instead of just being blank:

Design

We have a design for this in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5956-115842&t=dosxggnU7UlsrbfI-0

Screenshot:
image

For details, see the Figma doc.

The design relies on having a way to start a new DM conversation:

So this issue won't be ready to work on until that one is done.

Related issues

@chrisbobbe chrisbobbe added the a-design Visual and UX design label Nov 17, 2023
@gnprice gnprice added this to the Beta 2 milestone Nov 17, 2023
@gnprice gnprice added the a-home The home screens of the app; finding and starting conversations label Nov 17, 2023
@chrisbobbe
Copy link
Collaborator Author

Once we do this (or #386, for the inbox), let's revisit SubscriptionListPage (titled "Streams") to make sure it looks consistent with what we do here. Here's what that page currently does:

@sm-sayedi
Copy link
Collaborator

I would like to work on this issue!

So far that I have worked on it, it just shows a message like this at the center of the page:

@chrisbobbe
Copy link
Collaborator Author

Thanks for your interest, @sm-sayedi! I think this issue isn't ripe to work on yet, though. We'll want our designer to suggest how this should look.

@alya
Copy link
Collaborator

alya commented Jan 2, 2025

We should keep the text consistent with the web app, unless there's a good reason for them to be different:

You have no direct messages yet! Why not start the conversation?

The rest of the visual design can be as in Figma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design a-home The home screens of the app; finding and starting conversations
Projects
Status: No status
Development

No branches or pull requests

4 participants