Skip to content

Update topic input in channel compose box when topic moved #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Aug 2, 2024 · 0 comments
Open

Update topic input in channel compose box when topic moved #862

gnprice opened this issue Aug 2, 2024 · 0 comments
Labels
a-compose Compose box, autocomplete, attaching files/images a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Aug 2, 2024

This is a followup to #150 / #787. After that issue/PR, when you're looking at a TopicNarrow and the topic gets moved (with PropagateMode.changeAll or PropagateMode.changeLater), we'll update the page's narrow to follow along, and this will also mean that the send button in the compose box will point to the new narrow.

This issue is: If you're looking instead at a ChannelNarrow and you happen to have the moved topic selected in the compose box, then we should also follow along.

  • If the move happened within the channel, we should update the compose box's topic input.
  • If the move was to a different channel… TBD but we should probably switch to either the new TopicNarrow or its surrounding ChannelNarrow. The point is that if you hit send just after the move happens, we want the message to go to the conversation in its new location.

This is a behavior zulip-mobile doesn't have; instead we have a TODO comment (referring to zulip/zulip-mobile#5251):

          } else if (isStreamNarrow(narrow) && streamIdOfNarrow(narrow) === move.orig_stream_id) {
            // A ChatScreen showing the stream that contained the moved messages.
            //
            // TODO(#5251): Update topic input, if it matches.  (If the stream
            //   changed too, unclear what to do.  Possibly change the
            //   screen's narrow, as if narrowed to the moved topic?)
          }
        }

This point was previously described at #787 (comment) .

Related issues:

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-compose Compose box, autocomplete, attaching files/images labels Aug 2, 2024
@gnprice gnprice added this to the Post-launch milestone Aug 2, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

1 participant