notif android: Migrate to cross-platform Pigeon API for navigation#1447
Closed
rajveermalviya wants to merge 9 commits intozulip:mainfrom
Closed
notif android: Migrate to cross-platform Pigeon API for navigation#1447rajveermalviya wants to merge 9 commits intozulip:mainfrom
rajveermalviya wants to merge 9 commits intozulip:mainfrom
Conversation
Moves the actual loading of GlobalStore from GlobalStoreWidget to _ZulipAppState.initState. This will allow to do some other tasks concurrently while the GlobalStore is loading and showing the placeholder while they complete.
…art` This makes it clear that these bindings are for Android only.
…orDialog And fix a typo.
Introduces a new Pigeon API file, and adds the corresponding bindings in Swift. Unlike the `pigeon/android_notifications.dart` API this doesn't use the ZulipPlugin hack, as that is only needed when we want the Pigeon functions to be available inside a background isolate (see doc in `zulip_plugin/pubspec.yaml`). Since the notification tap will trigger an app launch first (if not running already) anyway, we can be sure that these new functions won't be running on a Dart background isolate, thus not needing the ZulipPlugin hack.
rajveermalviya
force-pushed
the
pr-migrate-android-notif
branch
from
1ad7dd8 to
54fb403
Compare
rajveermalviya
added
the
maintainer review
Collaborator
|
Is this superseded by #2043; should we close this? |
Member
Author
|
Correct, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #1379.
Migrates the Android notification routing implementation from URL-encoded payloads to instead implement and use the same Pigeon API that iOS uses in #1379.