Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes sends null bytes in message content #1248

Open
timabbott opened this issue Oct 2, 2017 · 2 comments
Open

Sometimes sends null bytes in message content #1248

timabbott opened this issue Oct 2, 2017 · 2 comments
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending bug

Comments

@timabbott
Copy link
Member

We've been getting some exceptions in production in the send_message code path of this form:

ValueError: A string literal cannot contain NUL (0x00) characters.

I'm going to fix this in the server to be a 400 type error, since it's an invalid request from the client, not a 500, but these are definitely being sent by the mobile app.

I'm not sure how the app generates a message body that contains null characters; if adding logging on the server side would be useful, that's doable (it's possible these are effectively empty messages).

@timabbott timabbott added the bug label Oct 2, 2017
@borisyankov
Copy link
Contributor

I will try to figure out it out.
Having the user-agent string would be useful though to detect platform and version.
We haven't fixed any issue like this, so likely this exists in the latest version too.

@timabbott
Copy link
Member Author

Yeah, the part of the error email reporting that would have the app version are currently broken, so I can't get that, but we'll get it if it keeps happening after we fix that.

@gnprice gnprice added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending bug
Projects
None yet
Development

No branches or pull requests

3 participants