Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive space around numbered list #4492

Open
gnprice opened this issue Feb 20, 2021 · 1 comment · May be fixed by #4495
Open

Excessive space around numbered list #4492

gnprice opened this issue Feb 20, 2021 · 1 comment · May be fixed by #4495
Assignees
@rajprakash00
Labels
a-layout a-message list help wanted

Comments

@gnprice
Copy link
Member

gnprice commented Feb 20, 2021

@kasperg reported the following behavior at zulip/zulip#17284:
image

There are two things that are quite wrong here:

  1. There's too much space between the paragraph and the following list.
  2. The list items are too deeply indented.

By contrast, we have pretty reasonable behavior with a plain bulleted list. We should use the same spacing for numbered lists as for bulleted lists.

(It's possible the spacing for bulleted lists should be slightly tweaked, too. But first let's make both kinds behave the same way, and then we can tweak them both together.)

A good comparison to look at is the webapp's behavior. See zulip/zulip@03e4ccb which recently adjusted this for the webapp.
@rajprakash00
Copy link
Contributor

@gnprice Can i work on this issue?

rajprakash00 added a commit to rajprakash00/zulip-mobile that referenced this issue Feb 23, 2021
@rajprakash00
Message-view: Fix excessive spacing for lists followed by paragraphs.
d07ac4a 
Previously there was an excessive space for ordered lists coming after
a paragraph unlike plain bulleted lists.This was already fixed in webapp
message-list view in #17285.

We fixed this in mobile app by following same spacing as of bulleted
lists coming after paragraph.

Fixes: zulip#4492
Signed-off-by: rajprakash00 <[email protected]>
@rajprakash00 rajprakash00 linked a pull request Feb 23, 2021 that will close this issue
Open
rajprakash00 added a commit to rajprakash00/zulip-mobile that referenced this issue Apr 30, 2021
@rajprakash00
Message-view: Fix excessive spacing for lists followed by paragraphs.
3661219 
Previously there was an excessive space for ordered lists coming after
a paragraph unlike plain bulleted lists.This was already fixed in webapp
message-list view in #17285.

We fixed this in mobile app by following same spacing as of bulleted
lists coming after paragraph.

Fixes: zulip#4492
Signed-off-by: rajprakash00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajprakash00 rajprakash00

Labels
a-layout a-message list help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Message-view: Fix excessive spacing for lists followed by paragraphs. rajprakash00/zulip-mobile
2 participants
@gnprice @rajprakash00