From 6527c1fb0e9c67e5aeef6d828e23aa40c4abe662 Mon Sep 17 00:00:00 2001 From: u7327620 Date: Sun, 20 Oct 2024 19:51:35 +1100 Subject: [PATCH] messages: Show headers if is_search_narrow(). Previously, when text searching, messages appear adjacently under the same heading, this can be confusing since they appear sequentially but there may be messages inbetween that don't meet the search criteria. Fixes #1550. --- zulipterminal/ui_tools/messages.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/zulipterminal/ui_tools/messages.py b/zulipterminal/ui_tools/messages.py index b8552fdc92..c19ce3221a 100644 --- a/zulipterminal/ui_tools/messages.py +++ b/zulipterminal/ui_tools/messages.py @@ -121,6 +121,14 @@ def need_recipient_header(self) -> bool: if len(self.model.narrow) == 2 and self.model.narrow[1][0] == "topic": return False + if self.model.is_search_narrow(): + if len(self.model.narrow) == 1: + return True + if len(self.model.narrow) == 2: + return self.message["type"] != "private" + if len(self.model.narrow) == 3: + return self.model.narrow[1][0] != "topic" + last_msg = self.last_message if self.message["type"] == "stream": return not (