Code cleanup

Author: zxPhoenix

src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java

@@ -1034,8 +1034,8 @@ RequestValidator requestValidator(
             JacksonMapper mapper,
             @Value("${logging.sampling-rate:0.01}") double logSamplingRate,
             @Value("${auction.strict-app-site-dooh:false}") boolean enabledStrictAppSiteDoohValidation,
-            @Value("${settings.fail-on-disabled-bidders}") boolean failOnDisabledBidders,
-            @Value("${settings.fail-on-unknown-bidders}") boolean failOnUnknownBidders) {
+            @Value("${settings.fail-on-disabled-bidders:true}") boolean failOnDisabledBidders,
+            @Value("${settings.fail-on-unknown-bidders:true}") boolean failOnUnknownBidders) {
 
         return new RequestValidator(
                 bidderCatalog,

src/main/java/org/prebid/server/validation/RequestValidator.java

@@ -134,7 +134,7 @@ public ValidationResult validate(Account account,
                     validateTargeting(targeting);
                 }
                 aliases = ObjectUtils.defaultIfNull(extRequestPrebid.getAliases(), Collections.emptyMap());
-                validateAliases(aliases, warnings, metrics, account);
+                validateAliases(aliases, warnings, account);
                 validateAliasesGvlIds(extRequestPrebid, aliases);
                 validateBidAdjustmentFactors(extRequestPrebid.getBidadjustmentfactors(), aliases);
                 validateExtBidPrebidData(extRequestPrebid.getData(), aliases, isDebugEnabled, warnings);
@@ -514,16 +514,16 @@ private static void validateGranularityRangeIncrement(ExtGranularityRange range)
      * is equals to itself.
      */
     private void validateAliases(Map<String, String> aliases, List<String> warnings,
-                                 Metrics metrics, Account account) throws ValidationException {
+                                 Account account) throws ValidationException {
 
         for (final Map.Entry<String, String> aliasToBidder : aliases.entrySet()) {
             final String alias = aliasToBidder.getKey();
             final String coreBidder = aliasToBidder.getValue();
             if (!bidderCatalog.isValidName(coreBidder)) {
                 metrics.updateUnknownBidderMetric(account);
 
-                final String message = String.format("request.ext.prebid.aliases.%s refers to unknown bidder: %s",
-                        alias, coreBidder);
+                final String message = "request.ext.prebid.aliases.%s refers to unknown bidder: %s".formatted(alias,
+                        coreBidder);
                 if (failOnUnknownBidders) {
                     throw new ValidationException(message);
                 } else {
@@ -532,8 +532,8 @@ private void validateAliases(Map<String, String> aliases, List<String> warnings,
             } else if (!bidderCatalog.isActive(coreBidder)) {
                 metrics.updateDisabledBidderMetric(account);
 
-                final String message = String.format("request.ext.prebid.aliases.%s refers to disabled bidder: %s",
-                        alias, coreBidder);
+                final String message = "request.ext.prebid.aliases.%s refers to disabled bidder: %s".formatted(alias,
+                        coreBidder);
                 if (failOnDisabledBidders) {
                     throw new ValidationException(message);
                 } else {