fix: harden autofix paths and isolate CodeQL output - #598
Merged
Conversation
Collaborator
Author
|
Reviewed the rs/no-path-traversal annotations: the scan root is the operator-selected boundary, and finding targets are canonicalized then required to remain within that directory (or equal the selected file) before reading/writing. The added tests exercise actual fixable findings and reject outside targets and escaping symlinks. These syntactic Path::new warnings do not identify an unguarded write. Semgrep CI failed before tests because the hosted runner had a partially installed Rust 1.88 toolchain / cargo-clippy file conflict; retrying that isolated job. |
peaktwilight
commented
Sep 10, 2026
peaktwilight
commented
Sep 10, 2026
✗ togi mutation report40.0% mutation score — 8/20 killed, 0 survived, 12 timeout, 0 build errors — 532.53s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Canonical confinement is a scope check, not a claim of race-proof filesystem isolation.
CodeQL output isolation found during CI
macOS concurrency-test repair
final_review_rendering_and_newer_admission_share_the_pull_request_gatewas stuck after the other 41 GitHub App tests completed.