fix(proxy): improve domain matching case insensitivity

[0x676e67]

backport: hyperium/hyper-util#251

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a fix to improve the robustness of domain matching within the proxy component. By implementing case-insensitive comparisons for domain names, it resolves an issue where proxy bypass rules might not have been consistently applied due to variations in domain casing. This change ensures more reliable and predictable proxy behavior across different domain name inputs.

Highlights

• Case-Insensitive Domain Matching: The DomainMatcher::contains method has been updated to perform case-insensitive comparisons when checking for direct domain matches that are prefixed with a dot. This ensures that domains like .foo.bar will correctly match foo.bar, FOO.BAR, or Foo.Bar.
• Enhanced Test Coverage: Two new unit tests, test_domain_matcher_case_insensitive and test_no_proxy_case_insensitive, have been added. These tests explicitly verify that the domain matching logic and the proxy interception mechanism correctly handle case-insensitive domain comparisons.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to make domain matching for proxy exclusion case-insensitive. The change correctly handles case-insensitivity for no_proxy entries that start with a dot. However, the implementation is incomplete and leaves two case-sensitive comparisons that will cause incorrect behavior for other no_proxy rules. I've provided suggestions to make all domain comparisons case-insensitive as expected.