Skip to content

[app] Landing page #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
citrusinesis wants to merge 1 commit into from
Closed

[app] Landing page #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.
1 change: 0 additions & 1 deletion packages/app/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const withBundleAnalyzer = require('@next/bundle-analyzer')({

module.exports = withPlugins(
{
swcMinify: true,
reactStrictMode: true,
compiler: {
emotion: true,
Expand Down
42 changes: 21 additions & 21 deletions packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,29 @@
"format": "prettier --write ."
},
"dependencies": {
"@emotion/react": "^11.11.3",
"@emotion/styled": "^11.11.0",
"class-variance-authority": "^0.7.0",
"clsx": "^2.1.0",
"lucide-react": "^0.338.0",
"next": "^14.1.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-is": "^18.2.0",
"tailwind-merge": "^2.2.1",
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.1",
"class-variance-authority": "^0.7.1",
"clsx": "^2.2.0",
Copy link
Member

@junhoyeo junhoyeo Sep 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clsx 등 없는 버전으로 변경되어 있어서 #7 에서 함께 수정했습니다 (workflow 에서 빌드 깨지는 거 이것 때문일 듯)

"lucide-react": "^0.544.0",
"next": "^15.5.3",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-is": "^19.0.0",
"tailwind-merge": "^3.3.1",
"tailwindcss-animate": "^1.0.7"
},
"devDependencies": {
"@next/bundle-analyzer": "^14.1.0",
"@next/bundle-analyzer": "^15.5.3",
"@trivago/prettier-plugin-sort-imports": "^4.3.0",
"@types/node": "^20.11.20",
"@types/react": "^18.2.58",
"@types/react-dom": "^18.2.19",
"autoprefixer": "^10.4.17",
"next-composed-plugins": "^1.0.1",
"postcss": "^8.4.35",
"prettier": "^3.2.5",
"tailwindcss": "^3.4.1",
"typescript": "^5.3.3"
"@types/node": "^22.10.1",
"@types/react": "^19.0.2",
"@types/react-dom": "^19.0.2",
"autoprefixer": "^10.4.21",
"next-composed-plugins": "^2.2.1",
"postcss": "^8.5.3",
"prettier": "^3.4.2",
"tailwindcss": "^3.4.15",
"typescript": "^5.6.3"
}
}
}
14 changes: 14 additions & 0 deletions packages/app/src/features/landing/LandingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import styled from '@emotion/styled';
import { NextPage } from 'next';

const LandingPage: NextPage = () => {
return <Container>Landing Page</Container>;
};

export default LandingPage;

const Container = styled.div`
width: 100%;
min-height: 100vh;
overflow-x: hidden;
`;
10 changes: 0 additions & 10 deletions packages/app/src/home/HomePage.tsx
View file
Open in desktop

This file was deleted.

Empty file added packages/app/src/hooks/.gitkeep
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion packages/app/src/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Document, { Head, Html, Main, NextScript } from 'next/document';
export default class MyDocument extends Document {
render() {
return (
<Html>
<Html suppressHydrationWarning>
Copy link
Member

@junhoyeo junhoyeo Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Html suppressHydrationWarning>
<Html>

@citrusinesis 발생 시 위치를 알기 위해서 전역에서는 해제하고, 고치는 것이 불가능하다고 판단되는 위치에만 따로 추가하거나 <NoSSR> 를 사용하는 것은 어떠세요?

<Head />

<body>
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from '@/home/HomePage';
export { default } from '@/features/landing/LandingPage';
7 changes: 7 additions & 0 deletions packages/app/src/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type Config = {
ENVIRONMENT: 'development' | 'production';
};

export const Config = {
ENVIRONMENT: process.env.NEXT_PUBLIC_ENVIRONMENT || 'development',
} as Config;
Loading
Loading