Feature - userId 해싱#156
Open
JiwonHwang01 wants to merge 7 commits into
Open
Conversation
Open
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/main/java/org/ktb/modie/service/MeetService.java:328
- [nitpick] The variable 'targetUserId' holds the decoded user id; consider renaming it to something like 'decodedUserId' for enhanced clarity.
String targetUserId = String.valueOf(hashIdUtil.decode(request.userId()));
src/main/java/org/ktb/modie/presentation/v1/controller/ChatHistoryController.java:84
- The 'hashIdUtil' is used here without being declared or injected in this controller; please ensure it is properly initialized.
String userHashId = hashIdUtil.encode(Long.parseLong(user.getUserId()));
duckchanahn
requested changes
Apr 7, 2025
| private final MeetRepository meetRepository; // MeetRepository 추가 | ||
| private final HashIdUtil hashIdUtil; | ||
|
|
||
| // 생성자 수정: MeetRepository도 주입받도록 수정 |
| HttpServletRequest request) { | ||
|
|
||
| Long meetId = hashIdUtil.decode(meetHashId); | ||
| System.out.println("getChatHistory start !! "); |
| chatList = chatRepository.findTop25ByMeetIdOrderByCreatedAtDesc(meetId, pageable); | ||
| } else { | ||
| chatList = chatRepository.findByMeetIdAndMessageIdLessThanOrderByCreatedAtDesc(meetId, lastChatId, | ||
| pageable); |
Member
There was a problem hiding this comment.
120자를 초과해서 줄을 띄워야할 때 파라미터를 모두 한 줄에 두면 더 보기 쉬울 거 같습니다 ! pageable만 다른 줄이 아닌 meetId도 다른 줄에 있도록 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
유저 Id hashing 처리
Related Issues
Changes Made
Testing
로그인 테스트가 필요해서 dev에 merge합니다.
Checklist