Release the EGL renderer when a texture view is disposed - #1859
Open
YuriiKruk wants to merge 1 commit into
Open
Conversation
HMSTextureRenderer.release() frees only the EGL surface, so every disposed HMSTextureView left its HandlerThread and EGL context alive for the process lifetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HMSTextureView.disposeTextureView() now releases the EGL renderer. Before this it freed only the drawing surface, so the render thread and the EGL context stayed alive for the lifetime of the process, and every texture view that was built and then removed left one behind.
The renderer field in HMSTextureRenderer is private, so it's read reflectively.
Fixes #1858
Additional context
Verified on a Pixel 6 by repeatedly building and disposing texture views while in a room. Debug build: 114 views created, 114 released, no renderer threads left afterwards. Release build: 81 created, 81 released, none left.
Pre-launch Checklist
///).