Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-language Support and Refactor Installation and Control Scripts #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Notorious-Ali
Copy link

@Notorious-Ali Notorious-Ali commented Aug 27, 2024

Description

  • Enhanced Language Support:

    • Added Language Files: Introduced language-specific files en.sh, fa.sh, and zh.sh for English, Persian, and Chinese, respectively.
    • Dynamic Language Selection: Implemented language selection functionality in quick_start.sh, install.sh, and 1pctl scripts to support multiple languages.
  • Updated Scripts:

    • install.sh:
      • Integrated language variables to replace hard-coded text.
      • Added logic to handle language selection and file loading based on user preference.
    • 1pctl:
      • Updated to support language selection similar to install.sh.
      • Enhanced prompts and messages to utilize language-specific variables.
    • quick_start.sh:
      • Implemented user language selection and saved the choice for future use.

Files Modified

  • 1pctl: Added language handling and updated user interface messages.
  • install.sh: Refactored to use language-specific variables and improved error handling.
  • quick_start.sh: Added language selection logic and file handling.
  • lang/en.sh: English language file.
  • lang/fa.sh: Persian language file.
  • lang/zh.sh: Chinese language file.

This commit enhances the user experience by allowing interaction in multiple languages and improves script usability across different locales.

  • Made sure tests are passing and test coverage is added if needed

Copy link

f2c-ci-robot bot commented Aug 27, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wanghe-fit2cloud
Copy link
Member

感谢支持 🙏

Copy link

f2c-ci-robot bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Notorious-Ali

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants