Skip to content

Fix some issues with bootstrap modals #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some issues with bootstrap modals #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions snippets/bootstrap/components/modal/customize.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<!-- Button trigger modal -->
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modelId}">
${1:Launch}
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modalId}">
${1:Launch}
</button>

<!-- Modal -->
<div class="modal fade" id="${2:modelId}" tabindex="-1" role="dialog" aria-labelledby="${4:modelTitleId}" aria-hidden="true">
<div class="modal fade" id="${2:modalId}" tabindex="-1" role="dialog" aria-labelledby="${4:modalTitleId}" aria-hidden="true">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-header">
<h5 class="modal-title" id="${4:modalTitleId}">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-body">
<div class="container-fluid">
${7:Add rows here}
Expand All @@ -27,7 +27,7 @@ <h5 class="modal-title">${3:Modal title}</h5>
</div>

<script>
$('#exampleModal').on('show.bs.modal', event => {
$('#${2:modalId}').on('show.bs.modal', event => {
var button = $(event.relatedTarget);
var modal = $(this);
// Use above variables to manipulate the DOM
Expand Down
14 changes: 7 additions & 7 deletions snippets/bootstrap/components/modal/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<!-- Button trigger modal -->
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modelId}">
${1:Launch}
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modalId}">
${1:Launch}
</button>

<!-- Modal -->
<div class="modal fade" id="${2:modelId}" tabindex="-1" role="dialog" aria-labelledby="${4:modelTitleId}" aria-hidden="true">
<div class="modal fade" id="${2:modalId}" tabindex="-1" role="dialog" aria-labelledby="${4:modalTitleId}" aria-hidden="true">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
<h5 class="modal-title" id="${4:modalTitleId}">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-body">
${7:Body}
Expand Down
18 changes: 9 additions & 9 deletions snippets/bootstrap/components/modal/grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<!-- Button trigger modal -->
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modelId}">
${1:Launch}
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modalId}">
${1:Launch}
</button>

<!-- Modal -->
<div class="modal fade" id="${2:modelId}" tabindex="-1" role="dialog" aria-labelledby="${4:modelTitleId}" aria-hidden="true">
<div class="modal fade" id="${2:modalId}" tabindex="-1" role="dialog" aria-labelledby="${4:modalTitleId}" aria-hidden="true">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-header">
<h5 class="modal-title" id="${4:modalTitleId}">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-body">
<div class="container-fluid">
${7:Add rows here}
Expand Down
16 changes: 8 additions & 8 deletions snippets/bootstrap/components/modal/sizes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<!-- Button trigger modal -->
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modelId}">
${1:Launch}
<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#${2:modalId}">
${1:Launch}
</button>

<!-- Modal -->
<div class="modal fade" id="${2:modelId}" tabindex="-1" role="dialog" aria-labelledby="${5:modelTitleId}" aria-hidden="true">
<div class="modal-dialog modal-${3:sm|lg}" role="document">
<div class="modal fade" id="${2:modalId}" tabindex="-1" role="dialog" aria-labelledby="${4:modalTitleId}" aria-hidden="true">
<div class="modal-dialog modal-${5:sm|lg}" role="document">
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
<h5 class="modal-title" id="${4:modalTitleId}">${3:Modal title}</h5>
<button type="button" class="close" data-dismiss="modal" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>
</div>
<div class="modal-body">
${8:Body}
Expand Down