Skip to content

Youngmin #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yym0329 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Youngmin #3

yym0329 wants to merge 2 commits into from

Conversation

@yym0329
Copy link

@yym0329 yym0329 commented May 1, 2023

  • RESTful API 구현
  • bcrypt 라이브러리 이용하여 password encryption 구현한듯?

@Byunk Byunk changed the title Password Encryption implemented Youngmin May 1, 2023
Byunk
Byunk approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@Byunk Byunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good~

src/app/controllers/user.controller.ts Outdated
export async function createUser(req: Request, res: Response, next: NextFunction) {
try {
const { username, password, name, email }: { username: string; password: string; name: string; email: string } = req.body;
const user: UserDocument = await User.create({ username, password, name, email });
Copy link
Member

@Byunk Byunk May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await User.create(
{
username: username,
password: hashedPassword,
name: name,
email: email,
})

src/app/schemas/user.schema.ts
export interface IUser extends Document {
username: string;
password: string;
hashedPassword: string;
Copy link
Member

@Byunk Byunk May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password와 hashedPassword를 분리할 필요는 없을 것 같아요.
Encrypted된 password만 DB에 저장하는 것이 목표입니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byunk Byunk Byunk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yym0329 @Byunk