Fix non-vectorized case w 21cmEMU #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 73.53% 73.44% -0.09%
==========================================
Files 8 8
Lines 2154 2158 +4
==========================================
+ Hits 1584 1585 +1
- Misses 570 573 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
steven-murray
approved these changes
Apr 10, 2024
Member
steven-murray
left a comment
steven-murray
left a comment
There was a problem hiding this comment.
Great! I just made one comment, but then it's fine
| for t in zip(*values): | ||
| ap.append(dict(zip(keys, t))) | ||
| astro_params = np.array(ap, dtype=object) | ||
| if all(isinstance(v, (float, int)) for v in values) and len(values) > 0: |
Member
There was a problem hiding this comment.
this should probably be an elif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error when setting
vectorized = Falsein the MCMC options while using21cmEMU.