feat: Issue #48 feature 1 #49
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 85.44% 82.95% -2.50%
==========================================
Files 11 11
Lines 742 827 +85
Branches 188 206 +18
==========================================
+ Hits 634 686 +52
- Misses 44 62 +18
- Partials 64 79 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
steven-murray
left a comment
steven-murray
left a comment
There was a problem hiding this comment.
OK, I got through most of it and it looks decent, but got super confused on some important stuff. When that gets cleared up I'll have a better look at the example notebooks.
| sigma is set to zero for uv cells with less than | ||
| this number of baselines. |
There was a problem hiding this comment.
Technically, I think sigma should be set to np.inf... if in the end we do want to do inverse-variance weighting, np.inf will make this seamless.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@nikos-triantafyllou and @DanielaBreitman I made some substantial updates on this PR, adding a lot of documentation and also changing some of the function names to be more clear. @nikos-triantafyllou I'd be grateful if you could have another play with it -- the main example notebook has been updated to give you a head-start. But it only uses artificial lightcones, not realistic ones, so it would be good to have a look at those to catch any obvious errors. Also, you'll need rasg-affiliates/21cmSense#215 to run this. |
| "source": [ | ||
| "Now that we have the baseline groups and the time offsets, we take the baseline groups and move them for each time offset as the sky rotates over the instrument:" | ||
| "kperp_grid = np.fft.fftfreq(lc_shape[0], d=boxlength)\n", | ||
| "ugrid = kperp_grid/dk_du(z" |
There was a problem hiding this comment.
Something weird is going on here. A ")" is missing, but also "z" is not defined before. I guess this notebook was not fully updated. But I think this version has something wrong with the uv coverage.
There was a problem hiding this comment.
Ah yeah, I started working on this notebook and didn't get further, because I wanted to test that things were working first.
| " weights=weights,\n", | ||
| " time_offsets=time_offsets,\n", | ||
| " frequencies=freqs,\n", | ||
| " ugrid_edges=\n", |
Fixes for issue #48.