Skip to content

Fix 2 wedge removal bugs: Unnecessary Fourier shifting and only removing positive k_parallel #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikos-triantafyllou wants to merge 2 commits into
base: better_lc_noise
Choose a base branch
from
Open

Fix 2 wedge removal bugs: Unnecessary Fourier shifting and only removing positive k_parallel #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df6ea78
Fix 2 wedge removal bugs: Unnecessaru Fourier shifting and only remov…
Oct 24, 2025
ee0fcd7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/tuesday/core/instrument_models/noise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,12 +415,7 @@ def filter_chunk(uv_chunk, freqs_chunk):

uvtau = np.fft.fft(uv_chunk, axis=-1)
this_dnu = np.mean(np.diff(freqs_chunk))
tau = (
np.fft.fftshift(
np.fft.fftfreq(uv_chunk.shape[-1], d=this_dnu.to(un.Hz).value)
)
* un.s
)
tau = np.fft.fftfreq(uv_chunk.shape[-1], d=this_dnu.to(un.Hz).value) * un.s

kperp_mag = np.add.outer(kperp_grid**2, kperp_grid**2) ** 0.5
umag = kperp_mag / dk_du(f2z(f0), with_h=with_h)
Expand All @@ -429,7 +424,7 @@ def filter_chunk(uv_chunk, freqs_chunk):
# frequencies are probably not exactly regular).
wedge = wedge_slope * umag / f0

mask = tau[None, None] < wedge[:, :, None] + buffer
mask = np.abs(tau)[None, None] < wedge[:, :, None] + buffer
uvtau[:, mask] = 0.0
return np.fft.ifft(uvtau, axis=-1)

Expand Down
Loading