fix: Add encoding for additional special characters in encodeQueryValue #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimjeongwonn is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Do you have an example nginx setup (version + config) where this occurs that I can try? Anyway, this would be a breaking (behavioural) change so it will only land in [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add {}|^? to the list of special characters that are encoded in the encodeQueryValue function.
Motivation
According to RFC 3986, certain special characters that are not included in the allowed URI character set can cause some nginx servers to return errors, making the site inaccessible when these characters appear in query parameters.
To address this issue, we are adding encoding for {}|^? characters. While I understand that PR #372 implemented custom encoding rules instead of using encodeURIComponent to keep URLs more readable, I believe proper functionality should take priority over aesthetic considerations.
Additionally, the reason for encoding ? is that some websites use ? as a delimiter to split strings in their logic. If ? characters in query values are not encoded, it could lead to unexpected parsing issues. For safety and reliability, we should encode ? characters as well.