-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Snapshot Save Single Action #7500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
b9b2b6a
first commit
NeylMahfouf2608 824ef94
TOFIX
NeylMahfouf2608 806e759
psuh for save
NeylMahfouf2608 4d6719a
WIP working version with saving on localstorage
NeylMahfouf2608 91eb239
Update Model3DRuntimeObject.ts
NeylMahfouf2608 1365d10
updated all runtimesobjects to have syncOptions, moved loading logic…
NeylMahfouf2608 751f71c
Update multiplayerobjectruntimebehavior.ts
NeylMahfouf2608 fd9331c
Update after clement comments on pr. Fixed several missed points and …
NeylMahfouf2608 d48b55c
last small details for concept (still needs support for expression ma…
NeylMahfouf2608 9b00761
Update PhysicsCharacter3DRuntimeBehavior.ts
NeylMahfouf2608 9e2bd6d
added a try catch for indexeDB opening
NeylMahfouf2608 15a6e97
wip soundManager management in save/load
NeylMahfouf2608 83bd850
fix soundManager save/load
NeylMahfouf2608 ace65de
small update (abort tween management)
NeylMahfouf2608 d5c4558
final functionnal commit to review
NeylMahfouf2608 8606b25
Update howler-sound-manager.ts
NeylMahfouf2608 8ac201c
Update howler-sound-manager.ts
NeylMahfouf2608 0f140c6
Update scenestack.ts
NeylMahfouf2608 cbc9975
Update scenestack.ts
NeylMahfouf2608 0860551
created loadRequestOptions type + added security and consistency on i…
NeylMahfouf2608 026f496
updated loadRequest signature and loading system in scenestack
NeylMahfouf2608 5f74967
fixed confusion between constants + added nullification for _loadRequ…
NeylMahfouf2608 1f3e8cd
forgot format
NeylMahfouf2608 082e7d2
[NOT WORKING] fixed variable null object misconception in savestate f…
NeylMahfouf2608 5ed0abd
Update scenestack.ts
NeylMahfouf2608 7711ea8
forced "syncOptions" parameter existence, repaired normalized value t…
NeylMahfouf2608 0b1f3b7
2 exemples for demonstrating the simplicity of the system
NeylMahfouf2608 7efb701
Improve naming and typing
AlexandreSi 78adaa6
Refactor loading logic
AlexandreSi 31d9ff4
Use array maps to simplify code reading
AlexandreSi 8be1d93
Update comment
AlexandreSi 9b76c5c
Prevent losing control when loading save
AlexandreSi 03dec17
Split responsibility into different booleans
AlexandreSi ac691a7
Rename instructions and parameters
AlexandreSi c06a5d4
Simplify logic
AlexandreSi f13feaa
Add TODOs
AlexandreSi a01507a
Use const variable
AlexandreSi aeeab60
Store data as a JS object
AlexandreSi 20203d8
WIP: Support saving and restoring tweens
AlexandreSi 049058e
Create tween setter factory
AlexandreSi c652778
Prettier
AlexandreSi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already done by
RuntimeObject3D?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it should, I don't think we need that, the super() call should handle it.