-
Notifications
You must be signed in to change notification settings - Fork 145
feat(binance): enhance WebSocket functionality and data retrieval #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
takltc
wants to merge
2
commits into
51bitquant:main
Choose a base branch
from
takltc:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+505
−69
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._loop: asyncio.AbstractEventLoop = get_loop() if _loop is None else _loop
self._loop: asyncio.AbstractEventLoop = None # Initialize as None, created in the run method
why? how do you test the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An asyncio event loop is not thread-safe. It is designed to be owned and managed by a single thread. The original code assigned the event loop in the init method, which runs in the main thread. The run() method, however, executes in a new, separate worker thread. Passing an event loop from one thread to another to be run can lead to race conditions and other unpredictable concurrency issues.
The best practice, which the new code follows, is that the thread that will run the event loop should be the one to create, manage, and eventually close it. By creating the loop inside the run() method, we ensure the new thread has its own private, isolated event loop, making the entire manager much more robust and predictable.
I added the test unit test_threaded_stream.py to test ThreadedApiManager by verifying that the thread can be started, is confirmed to be alive, and then can be stopped and cleaned up properly. Also, I simulate receiving a message from a socket and assert that the provided callback function is correctly invoked with the message content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,I will take a look. thanks for your PR. Best regards.