fix(build): reject mismatched board configuration - #2240
Open
QiuLsG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDF_TARGET_*as complete Kconfig symbols instead of prefixesconfig.json.targetreconfigurethat Kconfig retained the intended board selectionFixes #2239
Testing
python -m py_compile scripts/build.py scripts/tests/test_build.pypython -m unittest scripts.tests.test_build.VersionTests scripts.tests.test_build.BoardSelectionTests -v(21 passed)python scripts/build.py --list-boards(passed for the current 175-variant matrix)python -m unittest discover -s scripts/tests -v(72 executed; 5 pre-existing WindowsTemporaryDirectorycleanup errors remain because those tests try to delete their current working directory)ESP-IDF is not installed in this Windows environment, so no firmware build or physical hardware smoke test was performed.