Open
Conversation
Owner
|
Hey :> I'm curious to hear the reason you want to add this; what's the usecase? |
Author
|
Truthfully, my use case is to randomly sort albums of old photos to look through for fun, though I imagine this would be more useful if used in conjunction with a slideshow feature for e.g. turning an old device into a digital photo frame |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,

I want to preface this by saying that this is both my first PR to any project and my first time doing anything with Javascript. However it is very much working (for me, at least) on both Firefox and Chromium.
This adds a new sorting option, random, that shuffles the contents of the directory in a unique order each time it is selected.
I imagine there are likely changes that still need to be made for this to be production-ready which I had not managed to catch, but I figured I got somewhere and this may still be useful.
I modified
make-sfx.shbecause cp would error on that command without-ron the system I was using to build (AlmaLinux amd64), and the script would not finish.This PR complies with the DCO; https://developercertificate.org/