Nix: package web dependencies attempt 2#1252
Nix: package web dependencies attempt 2#1252toast003 wants to merge 6 commits into9001:hovudstraumfrom
Conversation
c970c15 to
4cb92d4
Compare
|
Package maintainer from Arch Linux here, I was doing this from a different direction. :) A few notes:
I was hoping to decouple the downloading of sources from building, e.g. having a multi-layer Dockerfile like this:
|
mainly with reproducible builds in mind, and after all it's only 106 bytes
|
sorry for the merge conflict; feel free to forcepush or rebase however you prefer 🙏 EDIT: just to mention I'll be mostly off-grid until the weekend, got a webbrowser but no ability to build anything o/ |
|
Dw @9001 , you're good!
What's your opinion on just using zopfli and/or fonttools from the repos? I can't really think of a reason to not use the repos, but since the Dockerfile gets specific versions I figured I might as well ask before doing anything |
good idea, and probably overdue -- they weren't packaged by alpine back then is all 👍 |
|
Definitely a lot better now. :) |
|
LGTM! not much to say, happy to merge unless you had more changes in mind 👍 |
|
Hi, I have some unpushed changes pending that are stuck on my main PC (ram failed, and warranty process is slow), so I have been focusing on other things for now. |
|
That said I would be ok to merge this rn without commit 43d48b2 if splitting the dockerfile is useful for other packages, like @grawlinson said. |
|
oof, dogspeed 🙏 and no rush of course o/ |
Better (hopefully) version of #897
Nix derivations run inside of a sandbox (think of docker, but more limited). Since we build web deps inside of a container anyways, this just extracts the commands from the Dockerfile so that we can run them inside the derivation for copyparty.
I didn't think this was feasible since you can't access the network from a normal derivation, until a while ago when I thought of using a fixed output derivation , which can access the network.
This would require a lot less maintenance than the previous pr, however it could be problematic since Nix enforces that fixed output derivations are reproducible.
To show that your contribution is compatible with the MIT License, please include the following text somewhere in this PR description:
This PR complies with the DCO; https://developercertificate.org/