Add codespell support (config, workflow to detect/not fix) and make it fix some typos#981
Add codespell support (config, workflow to detect/not fix) and make it fix some typos#981yarikoptic wants to merge 9 commits into9001:hovudstraumfrom
Conversation
| push: | ||
| branches: [hovudstraum] | ||
| pull_request: | ||
| branches: [hovudstraum] |
Scotsguy
left a comment
Scotsguy
left a comment
There was a problem hiding this comment.
A bunch of these are imo differences of style and not typos, some false positives too
| var ire = ebi('rn_re'), | ||
| ifmt = ebi('rn_fmt'), | ||
| ipre = ebi('rn_pre'), | ||
| idel = ebi('rn_pdel'), |
| """ | ||
| the default cert (and the entire TLS support) is only here to enable the | ||
| crypto.subtle javascript API, which is necessary due to the webkit guys | ||
| being massive memers (https://www.chromium.org/blink/webcrypto) |
There was a problem hiding this comment.
that's cool -- I didn't even know about such modern word ;) excluding!
There was a problem hiding this comment.
I force pushed with this excluded... not sure why here doesn't say "outdated".
| * you can successfully play `$'\355\221'` with mpv through mounting a remote copyparty server with rclone, pog | ||
| * `a`/copyparty remarks: | ||
| * extremely minimal samba/cifs server | ||
| * netscape 4 / ie6 support is mostly listed as a joke altho some people have actually found it useful ([ie4 tho](https://user-images.githubusercontent.com/241032/118192791-fb31fe00-b446-11eb-9647-898ea8efc1f7.png)) |
There was a problem hiding this comment.
altho -> although but not tho -> though?
There was a problem hiding this comment.
;-) nice observation. up to you -- we could exclude altho for symmetry or I could suggest tho -> though to codespell and fix here. Your desire?
There was a problem hiding this comment.
it's not my decision to make in the end, either :) I'm just some guy, you know
(I like the casual tone of altho, if it matters)
There was a problem hiding this comment.
why change the changelog retroactively?
There was a problem hiding this comment.
it is still a part of the "documentation" and I do not see why to keep it "buggy". But it is easy to skip if you insist.
There was a problem hiding this comment.
It's also I think copied from https://github.com/9001/copyparty/releases for each release and therefore would get out of sync with those. it's probably not that big of a deal, tho
…nteractively
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 4",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…os automagically
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
e5114e4 to
83bc8a4
Compare
2 participants
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.
there might still be a few false positives to catch since overall a good number of fixes