Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hasAdditionalStacksPlugin check if using modules in plugins sec… #214

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

sampsasaarela
Copy link

Fixes _.get(...).includes is not a function error if serverless.yml looks like this:

plugins:
  localPath: './plugins'
  modules:
    - my-custom-plugin
    - serverless-domain-manager
    - serverless-dynamodb-local
    - serverless-offline

@designfrontier
Copy link

This is breaking me as well... it appears that this.service.plugins is not an array in the latest version of serverless. Which breaks the check

@vkartaviy
Copy link

I have fixed this by using pluginManager, see #222

Copy link
Collaborator

@AshanFernando AshanFernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sampsasaarela for the PR. There is another PR #222 for the same purpose sent later on. Will you be able to check whether there is anything we could get from it? I'm approving this, if there are any changes, please incorporate. Waiting for another review before merging.

@sampsasaarela
Copy link
Author

Thanks @sampsasaarela for the PR. There is another PR #222 for the same purpose sent later on. Will you be able to check whether there is anything we could get from it? I'm approving this, if there are any changes, please incorporate. Waiting for another review before merging.

I think both will do the job, but my version is not dependent parsePluginsObject, the only dependency is lodash as before and should be fully backward compatible.

@cyberwombat
Copy link

Can this be revisited? Still unable to use enhanced plugin setup. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants