Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variable resolving #230

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

AhmedNourJamalElDin
Copy link

Fixes issue #[229]

Changes:

Based on below this (section)[https://serverless.com/framework/docs/providers/aws/guide/plugins#serverless-instance], which is:

Note: Variable references in the serverless instance are not resolved before a Plugin's constructor is called, so if you need these, make sure to wait to access those from your hooks.

So I moved the calls to this.config to the function they need them

Demo Link: No demo

Screenshots for the change: check the changes tab in the pull request

@AhmedNourJamalElDin AhmedNourJamalElDin changed the title extract config when needed Allow variable resolving Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant