Refactor meal fetching and simplify FoodCard labels#2
Draft
marvin-heinrich wants to merge 2 commits intoAET-DevOps25:mainfrom
Draft
Refactor meal fetching and simplify FoodCard labels#2marvin-heinrich wants to merge 2 commits intoAET-DevOps25:mainfrom
marvin-heinrich wants to merge 2 commits intoAET-DevOps25:mainfrom
Conversation
Moved meal fetching logic to a separate function and added onMount data fetch in +page.ts. Simplified label rendering in FoodCard.svelte by condensing Icon usage. Updated CanteenController to always return 200 OK with an empty list instead of 204 No Content for empty meal results.
Updated getTodayMeals endpoint to return HTTP 204 No Content when the list of today's meals is empty, instead of returning an empty list with HTTP 200. This improves API clarity for clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved meal fetching logic to a separate function and added onMount data fetch in +page.ts. Simplified label rendering in FoodCard.svelte by condensing Icon usage. Updated CanteenController to always return 200 OK with an empty list instead of 204 No Content for empty meal results.