Introduce get_all and get_all_mut on tuple_list using handles #3427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riesentoaster
changed the title
|
I don't think that CI error has anything to do with this PR, right? |
addisoncrump
requested changes
Sep 12, 2025
|
I asked in the Rust discord and the consensus was: there is no ergonomic way to write this in Rust for now. We can look at frunk for inspiration, but reasoning about these tuple lists generically might just always suck for now. |
addisoncrump
force-pushed
the
feat/tuple-get-all
branch
from
2706715 to
44fb275
Compare
addisoncrump
force-pushed
the
feat/tuple-get-all
branch
from
44fb275 to
bcbb933
Compare
addisoncrump
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With handles, it was previously possible to retrieve a single element from a tuple_list. This PR introduces functions to retrieve tuples of elements based on tuples of handles.
Checklist
./scripts/precommit.shand addressed all comments