Conversation
addisoncrump
requested changes
Apr 19, 2026
| }; | ||
| match res { | ||
| Ok(()) => unreachable!(), | ||
| Ok(()) => (), |
Member
There was a problem hiding this comment.
No, this shouldn't be the case; forkserver should never return "Ok", this should indeed be unreachable.
Comment on lines
655
to
660
| #[cfg(unix)] | ||
| let use_fork = self.fork; | ||
| #[cfg(not(unix))] | ||
| let use_fork = false; | ||
|
|
||
| if use_fork { |
Member
There was a problem hiding this comment.
Replace with if cfg!(unix)
| Self::wait_for_child_processes(&mut handles, self.spawn_broker)?; | ||
| } | ||
| Ok(()) | ||
| Err(Error::shutting_down()) |
| } | ||
|
|
||
| Self::wait_for_child_processes(&mut handles, self.spawn_broker); | ||
| Self::wait_for_child_processes(&mut handles, self.spawn_broker)?; |
| } | ||
|
|
||
| Self::wait_for_pids(&handles, self.spawn_broker); | ||
| Self::wait_for_pids(&handles, self.spawn_broker)?; |
Comment on lines
767
to
771
| // This is the fork part for unix | ||
| #[cfg(not(unix))] | ||
| { | ||
| unreachable!("Forking not supported"); | ||
| } |
| } else { | ||
| log::info!("Client with pid {handle} exited with status {status}"); | ||
| crash_count += 1; | ||
| reasons.push(format!("Exited with status {status}")); |
Member
There was a problem hiding this comment.
This will get formatted weird by :?, maybe just push the status codes?
| if let Some(sig) = ecode.signal() { | ||
| if sig != libc::SIGINT && sig != libc::SIGTERM { | ||
| crash_count += 1; | ||
| reasons.push(format!("Killed by signal {sig}")); |
Member
There was a problem hiding this comment.
Similarly here, might be better to make a function-specific derived-debug enum with Killed(c_int), Exited(c_int) and push them here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI a bit more
Checklist
./scripts/precommit.shand addressed all comments