rewrite Pegsol in python #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/ruby | |||
|
|
|||
| require 'ftools' | |||
Member
There was a problem hiding this comment.
If ftools/fileutils is only used to create non-nested directories, then Dir.mkdir(string) is enough.
No need to require a library that may change again in the future.
jendrikseipp
requested changes
Jun 8, 2024
Collaborator
jendrikseipp
left a comment
jendrikseipp
left a comment
There was a problem hiding this comment.
Code looks good. I have some minor nitpicks, though. And we'll need a simple test for the new script.
| @@ -1,2 +1,4 @@ | |||
| test: | |||
| ruby converter.rb | |||
| # ruby -I. generator.rb | |||
Collaborator
There was a problem hiding this comment.
Can we remove the comment?
| test: | ||
| ruby converter.rb | ||
| # ruby -I. generator.rb | ||
| ./pegsol-instances.py # Only analyzes instances, doesn't generate them. |
Collaborator
There was a problem hiding this comment.
Can you add a simple test for the new Python script?
|
|
||
| The original code was probably written for ruby 1.8. | ||
| The code was fixed for ruby 2.x. | ||
| This ruby code reproduces instances takes from the book. |
Collaborator
There was a problem hiding this comment.
Suggested change
| This ruby code reproduces instances takes from the book. | |
| This ruby code reproduces instances taken from the book. |
|
|
||
| """ | ||
| A randomized Pegsol generator for sequential STRIPS with negative preconditions. | ||
| """ |
Collaborator
There was a problem hiding this comment.
Add: "Generated instances are not guaranteed to be solvable."
| parser.add_argument("--rowcuts", type=int, default=2, help="Number of rows to cut from each corner. Should be less than floor(rows/2)") | ||
| parser.add_argument("--colcuts", type=int, default=2, help="Number of cols to cut from each corner. Should be less than floor(cols/2)") | ||
| parser.add_argument("occupancy", type=float, help="Probability that the pegs are initially occupied. (0, 1]") | ||
| # parser.add_argument("--european", action="store_true", help="If present, corners are cut in a triangular form (a European pegsol board)") |
| # cols = 7 | ||
| # rowcuts = 2 | ||
| # colcuts = 2 | ||
| # occupancy = 0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.