Scanalyzer #24
Open
Scanalyzer #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I like the added documentation, but I think it's best not to include binary files (such as the PDF) in the repo. |
jendrikseipp
requested changes
Jun 8, 2024
| -h, --help show this help message and exit | ||
| --use-half-segments If present, each segment is split in half and moves independently. | ||
| --seed SEED random seed | ||
| --output OUTPUT output file name. If not provided, it writes to the stdout. |
Collaborator
There was a problem hiding this comment.
Suggested change
| --output OUTPUT output file name. If not provided, it writes to the stdout. | |
| --output OUTPUT output file name. If not provided, it writes to stdout. |
Collaborator
There was a problem hiding this comment.
Please remove the binary file and add a link to the PDF to the README instead: https://doi.org/10.1609/icaps.v20i1.13431 .
| action="store_true", | ||
| help="If present, each segment is split in half and moves independently.") | ||
| parser.add_argument("--seed", type=int, default=1, help="random seed") | ||
| parser.add_argument("--output", default=None, help="output file name. If not provided, it writes to the stdout.") |
Collaborator
There was a problem hiding this comment.
Suggested change
| parser.add_argument("--output", default=None, help="output file name. If not provided, it writes to the stdout.") | |
| parser.add_argument("--output", default=None, help="output file name. If missing, write to stdout.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.