-
Notifications
You must be signed in to change notification settings - Fork 32
Docker image for running generators #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| FROM ubuntu:18.04 | ||
|
|
||
| LABEL maintainer="Hector Palacios ([email protected])" | ||
|
|
||
| # Install required packages | ||
| RUN apt-get update \ | ||
| && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \ | ||
| bash-completion \ | ||
| ca-certificates \ | ||
| git \ | ||
| libseccomp-dev \ | ||
| python3 \ | ||
| python3-pip \ | ||
| python3-venv \ | ||
| squashfs-tools \ | ||
| tzdata \ | ||
| unzip \ | ||
| vim \ | ||
| wget \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN pip3 install --upgrade pip \ | ||
| && pip3 install setuptools | ||
|
|
||
| RUN dpkg --add-architecture i386 | ||
| RUN apt-get update \ | ||
| && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \ | ||
| build-essential \ | ||
| file \ | ||
| time \ | ||
| libc6-i386 \ | ||
| gcc-multilib \ | ||
| g++-multilib \ | ||
| libstdc++5:i386 \ | ||
| flex \ | ||
| bison \ | ||
| python \ | ||
| zlib1g-dev \ | ||
| cmake | ||
|
|
||
| # && rm -rf /var/lib/apt/lists/* | ||
| # Not sure I need libc6-i386 | ||
| # g*-multilib is an overkill but will be useful for compiling | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In which scenarios do you think 32-bit compilations will be useful? I think we can remove them for simplicity. |
||
|
|
||
| RUN update-alternatives --install /usr/bin/python python /usr/bin/python3.6 1 && \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this for making |
||
| /usr/bin/python3 -m pip install --upgrade pip && \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haven't we updated pip already above? |
||
| pip3 install numpy z3-solver | ||
|
|
||
| # Install OpenJDK-11 | ||
| RUN apt-get update && \ | ||
| apt-get install -y openjdk-11-jre-headless && \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why use a separate apt-get call for JDK? |
||
| apt-get clean; | ||
|
|
||
| WORKDIR /mnt/pddl-generators | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN ./build_all save-logs | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you save the build logs? Couldn't they confuse users who just want to run the generators? You'll see the build output when the container is built, won't you? |
||
|
|
||
| # default command to execute when container starts | ||
| CMD /bin/bash | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,10 @@ Planning Competitions (IPC). | |
| * Build single generator: ``cd assembly; make`` | ||
| * Test generators: ``sudo apt install python-tox && tox`` | ||
|
|
||
| ## Docker instructions | ||
| * Build in Docker image: ``docker build -t pddl-generators .`` | ||
| * Run Docker container: ``docker run -ti -t pddl-generators`` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Double
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be good to use long option names for Docker beginners: --tag, --tty, --interactive |
||
|
|
||
| # Feedback | ||
| * Bug reports and pull requests are appreciated. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use 20.04?