-
Notifications
You must be signed in to change notification settings - Fork 35
Update to K* #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update to K* #147
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| singularity pull --name kstar.sif shub://ctpelok77/kstar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "name": "K* planner: integrating the K* algorithm into Fast Downward", | ||
| "description": "The first K∗ based solver for PDDL planning tasks; it is best suited for problems with very large solution set-size requirements (>1,000).", | ||
| "homepage": "https://github.com/ctpelok77/kstar", | ||
| "install-size": "36M", | ||
| "dependencies": [], | ||
| "endpoint": { | ||
| "services": { | ||
| "solve": { | ||
| "template": "planner", | ||
| "args":[ | ||
| { | ||
| "name": "search_algorithm", | ||
| "type": "categorical", | ||
| "description": "Search Algorithm", | ||
| "choices":[ | ||
| { | ||
| "display_value":"Kstar Blind k=1", | ||
| "value":"kstar(blind(),k=1)" | ||
| }, | ||
| { | ||
| "display_value":"Kstar Blind k=2", | ||
| "value":"kstar(blind(),k=2)" | ||
| } | ||
| ], | ||
| "default":"kstar(blind(),k=1)" | ||
| } | ||
| ], | ||
| "call":"{package_name} {domain} {problem} --search '{search_algorithm}'", | ||
| "return": { | ||
| "type": "generic", | ||
| "files": "found_plans/sas_plan.*" | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| singularity run -e $(dirname $0)/kstar.sif $@ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| rm kstar.sif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| singularity pull --name kstar.sif shub://ctpelok77/kstar | ||
| python3 -m pip install kstar-planner==1.4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,19 @@ | ||
| { | ||
| "name": "K* planner: integrating the K* algorithm into Fast Downward", | ||
| "description": "The first K∗ based solver for PDDL planning tasks; it is best suited for problems with very large solution set-size requirements (>1,000).", | ||
| "homepage": "https://github.com/ctpelok77/kstar", | ||
| "install-size": "36M", | ||
| "name": "K* planner", | ||
| "description": "New implementation of K* search based on Fast Downward.", | ||
| "homepage": "https://github.com/ibm/kstar", | ||
| "install-size": "203M", | ||
| "dependencies": [], | ||
| "endpoint": { | ||
| "services": { | ||
| "solve": { | ||
| "template": "planner", | ||
| "args":[ | ||
| { | ||
| "name": "search_algorithm", | ||
| "type": "categorical", | ||
| "description": "Search Algorithm", | ||
| "choices":[ | ||
| { | ||
| "display_value":"Kstar Blind k=1", | ||
| "value":"kstar(blind(),k=1)" | ||
| }, | ||
| { | ||
| "display_value":"Kstar Blind k=2", | ||
| "value":"kstar(blind(),k=2)" | ||
| } | ||
| ], | ||
| "default":"kstar(blind(),k=1)" | ||
| } | ||
| ], | ||
| "call":"{package_name} {domain} {problem} --search '{search_algorithm}'", | ||
| "call":"{package_name} -k 10 -q 1.0 -H lmcut {domain} {problem} >> plan", | ||
| "return": { | ||
| "type": "generic", | ||
| "files": "found_plans/sas_plan.*" | ||
| "type": "log", | ||
| "files": "*plan*" | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| singularity run -e $(dirname $0)/kstar.sif $@ | ||
| kstar_planner $@ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| rm kstar.sif | ||
| python3 -m pip uninstall kstar-planner |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing that gives me pause. You've moved away all the configuration and hard-coded the cli options. Why not leave it exposed? Would kstar use these as defaults? If not, you could beef up the run shell script to look and set defaults.
The reason it's nice to expose these in the json as args is that it will pre-populate the UI for those settings (online editor, and I think vscode as well). So running kstar from there (hosted on solver.planning.domains), could be configured for the individual user.