Unify backend logging, add context keys, and capture uncaught exceptions#425
Open
Unify backend logging, add context keys, and capture uncaught exceptions#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
sys.excepthookand an asyncio loop exception handler to surface unhandled exceptions with tracebacks via Loguru inbackend/logging_config.py.request_id,job_id,user_id) vialogger.configure(patcher=...)and included them in a sharedcommon_formatsologger.bind(...)context appears consistently.InterceptHandlerthat routes standardloggingrecords into Loguru and wireduvicorn,uvicorn.error, anduvicorn.accessto use this handler so they share the same sinks/format in both verbose and non-verbose modes.{exception}in the format so ERROR/CRITICAL logs that include exceptions still print full tracebacks.uvicorn.run(..., log_config=None)inbackend/start_alwrity_backend.pyso Uvicorn does not override the unified logging configuration.Testing
python -m compileall backend/logging_config.py backend/start_alwrity_backend.pyto validate syntax and byte-compile both modified modules, which completed successfully.backend/logging_config.pyandbackend/start_alwrity_backend.pyand that the startup invocation includeslog_config=None(no runtime tests were run as part of this change).Codex Task