Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SEOPageAuditrows without creating duplicate records.Description
persist_batch_size(default 50) and refactored_audit_urlsto collect per-page audit records in memory and flush them via a new_bulk_upsert_page_auditsfunction in batches._audit_single_urlto stop performing DB writes and instead return structured results includingaudit_recordandfailure_reason, so concurrent tasks do not share mutable session-side writes._build_audit_recordto create per-page payloads,_update_progressto persist periodic progress intotask.payloadandtask_log.result_data, and aggregated failure analytics (top_fail_reasons) and idempotency metadata in the final result.failure_detailsandexecution_summary(includingsuccess_rate,duration_ms) in task results.Testing
python -m compileall backend/services/scheduler/executors/onboarding_full_website_analysis_executor.pyand it succeeded.Codex Task