docs: make error output consistent with readme #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmccallum
requested changes
Oct 16, 2025
Collaborator
npmccallum
left a comment
npmccallum
left a comment
There was a problem hiding this comment.
Please also squash your commits.
markg-github
force-pushed
the
improve/gh_authentication
branch
from
94572ac to
b84ee7c
Compare
npmccallum
requested changes
Oct 17, 2025
markg-github
force-pushed
the
improve/gh_authentication
branch
from
b84ee7c to
7a51aa5
Compare
npmccallum
requested changes
Oct 17, 2025
Collaborator
npmccallum
left a comment
npmccallum
left a comment
There was a problem hiding this comment.
improve is not a valid conventional commit type. See https://www.conventionalcommits.org/en/v1.0.0/#summary
npmccallum
force-pushed
the
improve/gh_authentication
branch
from
7a51aa5 to
75d980f
Compare
Collaborator
|
@markg-github You can see I've added a linter for conventional commit syntax and your PR now doesn't pass that test. |
Improve dispatch error output when dispatch fails to authenticate with GitHub by describing permissions needed to authenticate.
markg-github
force-pushed
the
improve/gh_authentication
branch
from
75d980f to
4e199d0
Compare
Contributor
Author
|
@npmccallum should be good now. |
npmccallum
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.