Create CPU scaling component stub #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-hiner
force-pushed
the
scaling/worker
branch
3 times, most recently
from
be3945b to
2bef35a
Compare
m-hiner
force-pushed
the
scaling/api-stub
branch
from
4b80dd7 to
52f87d1
Compare
m-hiner
force-pushed
the
scaling/worker
branch
from
2bef35a to
6fc92c5
Compare
m-hiner
force-pushed
the
scaling/api-stub
branch
2 times, most recently
from
e943d87 to
6603776
Compare
m-hiner
force-pushed
the
scaling/worker
branch
from
6fc92c5 to
e614087
Compare
m-hiner
force-pushed
the
scaling/api-stub
branch
from
6603776 to
62af5f8
Compare
m-hiner
force-pushed
the
scaling/worker
branch
from
e614087 to
1a90cb0
Compare
m-hiner
force-pushed
the
scaling/api-stub
branch
from
62af5f8 to
f390132
Compare
m-hiner
force-pushed
the
scaling/worker
branch
from
1a90cb0 to
55f0e86
Compare
m-hiner
force-pushed
the
scaling/api-stub
branch
from
06face8 to
f574deb
Compare
m-hiner
force-pushed
the
scaling/worker
branch
from
55f0e86 to
62b4b6e
Compare
m-hiner
force-pushed
the
scaling/worker
branch
3 times, most recently
from
6832ac3 to
ac63103
Compare
apolak
requested changes
Nov 25, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Some comments, mostly around the actual implementation. For now, I only left a few comments about tests. I still need to go through them in detail.
m-hiner
force-pushed
the
scaling/worker
branch
from
ac63103 to
a6e033f
Compare
rafal-lal
approved these changes
Nov 26, 2024
Collaborator
rafal-lal
left a comment
rafal-lal
left a comment
There was a problem hiding this comment.
I only have this as this was already reviewed.
m-hiner
force-pushed
the
scaling/worker
branch
3 times, most recently
from
167492f to
f136fde
Compare
apolak
requested changes
Nov 28, 2024
m-hiner
force-pushed
the
scaling/worker
branch
from
f136fde to
8b595c3
Compare
apolak
requested changes
Nov 29, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Just a few final comments and we should be good to go.
m-hiner
force-pushed
the
scaling/worker
branch
from
8b595c3 to
1e89c08
Compare
apolak
reviewed
Dec 2, 2024
Creates a stub implementation for CPU scaling component connected to CPUScalingConfiguration API. CPUScalingManager is the overarching interface for controlling workers on assigned CPUs and accepting new scaling configurations. CPUScalingWorker is run asynchronously and is responsible for storing the scaling configuration tied to the CPU and for calling the updater. CPUScalingUpdater is run as a part of worker and is responsible for performing actual scaling tasks based on scaling configuration received from the worker.
m-hiner
force-pushed
the
scaling/worker
branch
from
1e89c08 to
29afef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a stub implementation for CPU scaling component connected to CPUScalingConfiguration API.
CPUScalingManager is the overarching interface for controlling workers on assigned CPUs and accepting new scaling configurations.
CPUScalingWorker is run asynchronously and is responsible for storing the scaling configuration tied to the CPU and for calling the updater.
CPUScalingUpdater is run as a part of worker and is responsible for performing actual scaling tasks based on scaling configuration received from the worker.