Add CPUScalingConfiguration related logic to CPUScalingProfile Controller #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
5 times, most recently
from
3b943f6 to
3c6022b
Compare
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
2 times, most recently
from
de81400 to
0f7d21e
Compare
apolak
requested changes
Nov 27, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Didn't go through tests yet, but these are the comments I have so far.
rafal-lal
force-pushed
the
rlal/cpuscaling/logic
branch
from
8c0c141 to
592fc09
Compare
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
from
301a39e to
117e2bf
Compare
rafal-lal
force-pushed
the
rlal/cpuscaling/logic
branch
from
592fc09 to
3bc6f88
Compare
rafal-lal
changed the title
rafal-lal
force-pushed
the
rlal/cpuscaling/logic
branch
from
3bc6f88 to
2185c10
Compare
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
from
117e2bf to
ba62344
Compare
rafal-lal
changed the title
Collaborator
Author
|
@apolak Ready to reveiw again. |
rafal-lal
force-pushed
the
rlal/cpuscaling/logic
branch
2 times, most recently
from
b776be2 to
fb250a4
Compare
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
from
ba62344 to
d0f70d2
Compare
rafal-lal
force-pushed
the
rlal/cpuscaling/logic
branch
from
fb250a4 to
afb6a9c
Compare
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
2 times, most recently
from
e9ba782 to
b8d52ab
Compare
apolak
reviewed
Dec 3, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Some general comments about addressing code reuse/duplication.
apolak
reviewed
Dec 3, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Some general comments about tests. I will review the test cases tomorrow.
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
from
b8d52ab to
e55c6cc
Compare
apolak
reviewed
Dec 6, 2024
Collaborator
apolak
left a comment
apolak
left a comment
There was a problem hiding this comment.
Some final minor comments.
Signed-off-by: Rafal Lal <[email protected]>
rafal-lal
force-pushed
the
rlal/scalingprofile/scalingconfig
branch
from
4117810 to
32e2c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.