Skip to content

fix: only attach milestone if release build #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amd-aliem merged 1 commit into from
Oct 29, 2025
Merged

fix: only attach milestone if release build #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ jobs:
sudo apt update
sudo apt install -y mkosi

- name: Set dynamic mkosi vars
if: startsWith(github.ref, 'refs/tags/v')
run: |
sed -i "/^\[Service\]/a\Environment=\"SET_MILESTONE=true\"" modules/beacon/mkosi.extra/usr/local/lib/systemd/system/beacon-report.service

- name: Build guest-${{ matrix.distro }}-${{ matrix.release }}
run: |
sudo mkosi --image-id=guest-${{ matrix.distro }}-${{ matrix.release }} -C images/guest-${{ matrix.distro }}-${{ matrix.release }}/ cat-config
Expand Down
9 changes: 5 additions & 4 deletions modules/beacon/mkosi.extra/usr/local/lib/scripts/beacon-report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ set -euo pipefail

SEV_VERSIONS=("3.0-0")
SEV_CERT_FILE=""
SET_MILESTONE="${SET_MILESTONE:-false}"

# Determine OS name and version
if [ -f /etc/os-release ]; then
Expand All @@ -29,11 +30,11 @@ for sev_version in "${SEV_VERSIONS[@]}"; do
SEV_CERT_FILE="${HOME:-/root}/sev_certificate_v${sev_version}.txt"

# Call beacon
if [ -e "${SEV_CERT_FILE}" ] && [ -z "$(grep "❌" "${SEV_CERT_FILE}")" ]; then
# Add milestone if no errors encountered
beacon report --title "$SEV_TITLE" --body "$SEV_CERT_FILE" --label "certificate" --label "${OS_LABEL}" --milestone "v${sev_version}"
if [ -e "${SEV_CERT_FILE}" ] && [ -z "$(grep "❌" "${SEV_CERT_FILE}")" ] && [ "${SET_MILESTONE}" == "true" ]; then
# Add milestone if no errors encountered and if this is a release build.
beacon report --title "$SEV_TITLE" --body "$SEV_CERT_FILE" --label "certificate" --label "os-${OS_LABEL}" --milestone "v${sev_version}"
else
beacon report --title "$SEV_TITLE" --body "$SEV_CERT_FILE" --label "certificate" --label "${OS_LABEL}"
beacon report --title "$SEV_TITLE" --body "$SEV_CERT_FILE" --label "certificate" --label "os-${OS_LABEL}"
fi

echo "Published SEV certificate via beacon with title: $SEV_TITLE"
Expand Down