Beacon report fix for debian forky release #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshmiSaiHarika
force-pushed
the
beacon-report-fix-for-debian-forky
branch
from
edbbf6a to
32b21ad
Compare
DGonzalezVillal
requested changes
Nov 5, 2025
Contributor
DGonzalezVillal
left a comment
DGonzalezVillal
left a comment
There was a problem hiding this comment.
I say remove the pre-release milestone thing. Just certify the rolling release versions to the sev-certify version that it passes. The version-id change works well although.
|
|
||
| # Call beacon | ||
| if [ -e "${SEV_CERT_FILE}" ] && [ -z "$(grep "❌" "${SEV_CERT_FILE}")" ] && [ "${SET_MILESTONE}" == "true" ]; then | ||
| if [ -e "${SEV_CERT_FILE}" ] && [ -z "$(grep "❌" "${SEV_CERT_FILE}")" ] && [ "${SET_MILESTONE}" == "true" ] && [ "${OS_PRE_RELEASE}" == "true" ]; then |
Contributor
There was a problem hiding this comment.
The milestones are being used to tell us what sev-certify version the OS is certified in. so this pre-release milestone is confusing. I think it's fine if we just put the rolling release with the other official release. IT's technically not a "pre-release".
VERSION_ID environment variable is not present in /etc/os-release file in the Debian forky release. Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
force-pushed
the
beacon-report-fix-for-debian-forky
branch
from
32b21ad to
067e214
Compare
DGonzalezVillal
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian Forky SNP certification GH Issue link: here